Add checked information for compound statements to AST reading/writing#716
Merged
Conversation
added 3 commits
October 30, 2019 17:47
…into issue419-read-write-compound-checked
dtarditi
approved these changes
Nov 6, 2019
dtarditi
left a comment
dtarditi
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks! The pch tests probably need to moved to a subdirectory. That can be done separately.
This was referenced Nov 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Issue #419): Modify ASTWriterStmt and ASTReaderStmt to write/read the checked scope specifier and written checked scope specifier for compound statements.
Future work: add checked information for function declarations to ASTWriterDecl and ASTReaderDecl (see issue #704).
Testing:
-ast-dump-alloption to dump the AST of the precompiled header).